-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement API endpoints for Categories and Products #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change came about after a number of research. I found that JSON:API standard follows best practices and it's something I want to become very good at. Also, based on the benchmark tests, it is way faster than jbuilder and the alternatives I found.
This update makes the `category_id` on the `products` to be optional so that it doesn't need to be provided when a product does not fit into a category yet. It also ensures that when a category is deleted, the products that depend will have their `category_id` field set to null. Finally, `available` and `currency` have been introduced to the `products` to table to help know the availability status of a product and the currency it uses.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates add the necessary endpoints, controllers and tests for categories and products.
Currently, the API allows authorized users to perform CRUD operations on the products and categories objects.
The full documentation of the current API behaviour is available here.